Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: api 에러 처리 관심사 분리 #69

Merged
merged 9 commits into from
Jan 9, 2025
Merged

chore: api 에러 처리 관심사 분리 #69

merged 9 commits into from
Jan 9, 2025

Conversation

21ow
Copy link
Owner

@21ow 21ow commented Jan 8, 2025

📌 Related Issue

closed #68

📝 Description

  • try-catch문 없애고 데이터 패칭만 남겼습니다.
    에러나 로딩 처리는 리액트 쿼리로 하시면 될 것 같습니다.
  • 타입명 일부 수정했고, params 타입도 스웨거에 맞춰 바꾸었습니다.

@21ow 21ow added the 📬 API 외부 API 통합이나 API 요청/응답 기능을 추가하거나 수정한 경우 label Jan 8, 2025
@21ow 21ow self-assigned this Jan 8, 2025
minim1nh
minim1nh approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@minim1nh minim1nh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다

changhui-chan
changhui-chan approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@changhui-chan changhui-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인완료~1

@21ow 21ow merged commit 5750c05 into develop Jan 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minim1nh minim1nh minim1nh approved these changes

@changhui-chan changhui-chan changhui-chan approved these changes

Assignees

@21ow 21ow

Labels
📬 API 외부 API 통합이나 API 요청/응답 기능을 추가하거나 수정한 경우
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: api 에러 처리 관심사 분리
3 participants
@21ow @changhui-chan @minim1nh