Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 공용 쿼리 훅 수정 #35

Merged
merged 5 commits into from
Dec 30, 2024
Merged

fix: 공용 쿼리 훅 수정 #35

merged 5 commits into from
Dec 30, 2024

Conversation

21ow
Copy link
Owner

@21ow 21ow commented Dec 28, 2024

📌 Related Issue

closed #32

📝 Description

  • v1으로 롤백했습니다.
    수정이랑 테스트까지 다 하고 고민해봤는데 파일 개수 줄이는 것보다 쓰는 분들이 편한 게 맞는 것 같아서 전부 삭제하고 기존 버전으로 돌렸습니다.
    강의에서 배운대로 useQuery, useMutation 사용하면 될 것 같습니다.
  • 기존 api 함수들은 리팩토링 기간 때 좀 더 쳐내고, 리액트 쿼리 옵션으로 공통 에러 처리 정도만 할 것 같습니다.

@21ow 21ow added the 🐞 BugFix 발견된 오류나 버그를 수정한 경우 label Dec 28, 2024
@21ow 21ow self-assigned this Dec 28, 2024
changhui-chan
changhui-chan approved these changes Dec 29, 2024
View reviewed changes
Copy link
Collaborator

@changhui-chan changhui-chan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 린트랑 버셀쪽 에러나는데 그것만 체크해주심 될것같스빈당

@21ow 21ow merged commit 07f591e into develop Dec 30, 2024
2 checks passed
@21ow 21ow deleted the feauture/query-v3 branch December 30, 2024 06:54
21ow added a commit that referenced this pull request Jan 17, 2025
@21ow
fix: 공용 쿼리 훅 수정 (#35)
49cfa50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@changhui-chan changhui-chan changhui-chan approved these changes

Assignees

@21ow 21ow

Labels
🐞 BugFix 발견된 오류나 버그를 수정한 경우
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: 공용 쿼리 훅 수정
2 participants
@21ow @changhui-chan