Add support for setting minimum and maximum count of selected #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keichinger
force-pushed
the
choice-field-min-max
branch
2 times, most recently
from
5628c83 to
289bda0
Compare
apfelbox
reviewed
Oct 27, 2023
apfelbox
reviewed
Oct 27, 2023
keichinger
force-pushed
the
choice-field-min-max
branch
from
747560f to
50ebdd2
Compare
…for a required multi-select
apfelbox
reviewed
Oct 30, 2023
apfelbox
reviewed
Oct 30, 2023
apfelbox
reviewed
Oct 30, 2023
apfelbox
reviewed
Oct 30, 2023
src/Field/Definition/ChoiceField.php
Outdated
| ); | ||
| } | ||
|
|
||
| $choicesConstraints = $this->choices->getValidationConstraints(true); |
There was a problem hiding this comment.
Now that I see that: I really dislike this API. We need to change it in the next major version 😅
apfelbox
reviewed
Oct 30, 2023
apfelbox
reviewed
Oct 30, 2023
apfelbox
reviewed
Oct 30, 2023
apfelbox
reviewed
Oct 30, 2023
apfelbox
force-pushed
the
choice-field-min-max
branch
from
b1f1d6b to
10834f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.