Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add impl AsRef<[u8]> for Payload #265

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Conversation

zetanumbers
Copy link
Contributor

No description provided.

Copy link
Owner

@1c3t3a 1c3t3a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks :)

@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Merging #265 (7ed7545) into main (6acd555) will increase coverage by 0.36%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #265      +/-   ##
==========================================
+ Coverage   86.27%   86.63%   +0.36%     
==========================================
  Files          31       31              
  Lines        2478     2485       +7     
==========================================
+ Hits         2138     2153      +15     
+ Misses        340      332       -8     
Impacted Files Coverage Δ
socketio/src/payload.rs 86.20% <0.00%> (-13.80%) ⬇️
engineio/src/asynchronous/client/async_client.rs 96.27% <0.00%> (+0.67%) ⬆️
engineio/src/asynchronous/client/builder.rs 91.93% <0.00%> (+0.80%) ⬆️
engineio/src/asynchronous/async_socket.rs 71.28% <0.00%> (+0.99%) ⬆️
...asynchronous/async_transports/websocket_general.rs 80.00% <0.00%> (+1.81%) ⬆️
...eio/src/asynchronous/async_transports/websocket.rs 91.89% <0.00%> (+2.70%) ⬆️
.../asynchronous/async_transports/websocket_secure.rs 90.78% <0.00%> (+2.78%) ⬆️
...ineio/src/asynchronous/async_transports/polling.rs 78.31% <0.00%> (+3.61%) ⬆️
socketio/src/client/callback.rs 43.75% <0.00%> (+6.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@1c3t3a 1c3t3a merged commit 24d077f into 1c3t3a:main Dec 20, 2022
@zetanumbers zetanumbers deleted the payload-as-ref branch December 20, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants