Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize Done button title #143

Closed
wants to merge 3 commits into from

Conversation

viccc
Copy link

@viccc viccc commented Sep 6, 2015

Added ability to customize title for Done button.
Sample usage in CTUITweaksViewController, and CTCustomDoneButtonViewController (new sample controller, added to Appearance section).

This adds public interface (doneButtonTitle property), but in backwards-compatible way, so the version for CocoaPod might need to be incremented to 3.1.0. That is, if you choose to merge it - but please do. The obvious use case is, e.g. we use the picker to choose the images to be uploaded to a server, so we want this button to say "Upload" rather than "Done".

@1and2papa
Copy link
Owner

@viccc Won't it be more easier to make your own translation of "Done" in CTAssetsPicker.strings?

@1and2papa 1and2papa closed this Sep 14, 2015
1and2papa added a commit that referenced this pull request Nov 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants