Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip open on hover #218

Merged
merged 6 commits into from
Apr 12, 2022
Merged

Tooltip open on hover #218

merged 6 commits into from
Apr 12, 2022

Conversation

Corantin
Copy link
Collaborator

@Corantin Corantin commented Apr 9, 2022

  • Be able to hover on a help button to open the help tooltip
  • The tooltip should close when no more hover the help button
  • Remove now useless tooltip prop and keep tooltipDetail as tooltip everywhere in the app
  • Pimpup tooltip messages (I saw too much confusing tooltips)

closes #211

@vercel
Copy link

vercel bot commented Apr 9, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/1hive/quests/4t5jE3EKCcU23gEJnth4GckqLter
✅ Preview: https://quests-git-tooltip-open-on-hover-1hive.vercel.app

@codecov
Copy link

codecov bot commented Apr 9, 2022

Codecov Report

Merging #218 (396a074) into main (92147f4) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #218   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           25        25           
  Branches         5         5           
=========================================
  Hits            25        25           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92147f4...396a074. Read the comment docs.

@vercel vercel bot temporarily deployed to Preview April 10, 2022 23:32 Inactive
@Corantin Corantin changed the title DO NOT MERGE : Tooltip open on hover - Exploration Tooltip open on hover Apr 10, 2022
@vercel vercel bot temporarily deployed to Preview April 10, 2022 23:44 Inactive
@vercel vercel bot temporarily deployed to Preview April 10, 2022 23:54 Inactive
@vercel vercel bot temporarily deployed to Preview April 11, 2022 00:24 Inactive
@Corantin Corantin requested review from kafann and kamikazebr April 11, 2022 11:41
@vercel vercel bot temporarily deployed to Preview April 12, 2022 12:12 Inactive
@Corantin Corantin merged commit b8eaac6 into main Apr 12, 2022
@Corantin Corantin deleted the tooltip-open-on-hover branch April 12, 2022 17:58
@Corantin
Copy link
Collaborator Author

Aproved by Kafan in DM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip should be open on hover
1 participant