-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Some react render issues #214
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/1hive/quests/DhHDRkGw84KvTCeJcNGodK8FQsip |
Codecov Report
@@ Coverage Diff @@
## main #214 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 25 25
Branches 5 5
=========================================
Hits 25 25 Continue to review full report at Codecov.
|
fix: mainview inside router fix: fallback to QuestList
What was done:
Details
When realod some page like http://localhost:3000/#/detail?id=0xa7954D9085aC960bD489F24a7A60D0347a5a0Bd3
Quest details and wait for some time the request in background return but the components are unmounted.
And it leak memory.
The correct approach its not allow that components be loaded if not showed, but it fast fix for now.
Also added key props to render.
export const DEFAULT_PAGE = ENUM_PAGES.List;
setted to undefined as default to avoid load Dashboard and switch to QuestDetail