Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-13524: Validate login_bundle.pem for inclusion in ficam_bundle.pem #466

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

aduth
Copy link
Contributor

@aduth aduth commented Jun 5, 2024

🛠 Summary of changes

Updates certificate bundle validation task to check certificates for inclusion in the FICAM-distributed certificate bundle.

Related Slack discussion: https://gsa-tts.slack.com/archives/C05MGJ72GU9/p1717515786828179?thread_ts=1717433534.870859&cid=C05MGJ72GU9

📜 Testing Plan

Verify that the certificate bundle validation task (1) continues to validate existing checks for bundle regeneration and (2) checks for inclusion of certificates in the FICAM bundle:

  1. Reset to the commit prior to removing invalid certificates: git checkout 0bd01ee~1
  2. Run rake certs:check_certificate_bundle
  3. See error "Unexpected certificates in config/cert_bundles/login_bundle.pem not present in config/cert_bundles/ficam_bundle.pem" listing two certificates
  4. Remove the two listed certificates from config/certs
  5. Run rake certs:check_certificate_bundle
  6. See error "config/cert_bundles/login_bundle.pem does not match the certificates in config/certs" (existing check)
  7. Run rake certs:generate_certificate_bundles
  8. Run rake certs:check_certificate_bundle
  9. See no errors

@aduth aduth requested review from mitchellhenke and mdiarra3 June 5, 2024 12:41
@aduth aduth changed the title Validate login_bundle.pem for inclusion in ficam_bundle.pem LG-13524: Validate login_bundle.pem for inclusion in ficam_bundle.pem Jun 5, 2024


desc 'Check that LG certificate bundle matches certificates in certificate path'
desc 'Validate certificate bundle as matching certificate path and inclusion in FICAM'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forget -- how close are we to having those cert_bundles generated as part of the deploy process?

Copy link
Contributor Author

@aduth aduth Jun 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll sooner move to using a different bundle (related Slack discussion), which will probably still require some maintaining that we could/should incorporate into the deployment process, but wouldn't want to plan too much around it since it might work a little differently.

I'll create a ticket for it so that we don't lose track. (Edit: LG-13554)

@aduth aduth merged commit ded71dc into main Jun 6, 2024
1 check passed
@aduth aduth deleted the aduth-validate-login-ficam branch June 6, 2024 13:01
@aduth aduth mentioned this pull request Jun 6, 2024
@mitchellhenke mitchellhenke restored the aduth-validate-login-ficam branch June 13, 2024 17:49
@aduth aduth deleted the aduth-validate-login-ficam branch November 21, 2024 18:13
@mitchellhenke mitchellhenke restored the aduth-validate-login-ficam branch November 21, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants