Allow specifying days for expiration in print_expiring task and set it to zero in CI #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchellhenke
deleted the
mitchellhenke/do-not-fail-ci-on-future-expiring-cert
branch
mitchellhenke
restored the
mitchellhenke/do-not-fail-ci-on-future-expiring-cert
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
We don't necessarily want to fail on a cert that expires in the future, as it is still valid until then. We still have alerts based on the health check endpoint which we can rely on for notification for soon-to-expire certificates.
This PR changes it so that CI only fails if a cert is expired.