Deploy RC 451 to Production #11868
Merged
Deploy RC 451 to Production #11868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* LG-14933 Remove extra space from document capture form. The document capture success message intended for screen readers was taking up space on the screen, which was not intended as part of the design. changelog: bug fixes, document capture, remove space from document capture layout. Used a suggestion by Andrew Duthie to wrap the screen reader message in a span, to keep it from affecting the layout.
* LG-15559: Add support for A/B tests daily reporting changelog: Internal, A/B Tests, Add support for A/B tests daily reporting * Add expected progress argument value * Revise A/B test report options to struct See: #11835 (comment) * Return `nil` for report if option not passed * Memoize active value without modifying frozen instance * Update hash option to struct value * Avoid naming conflicts with existing report class for stubbed data * Format float_as_percent if between 0 and 1 * Handle Float::NAN when formatting float as percent * Use format method to format as percent Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Remove unused CLI supports Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Remove unused CloudwatchClient options * Add method visibility for public API * Fix YARDoc param type for queries * Format numbers outside 0-1 as percent See: #11835 (comment) * Fix spec row label to increment --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* changelog: Bug Fixes, accessibility and authorization, modal has been added/included that gives the user the ability to extend time with current session * refactor tests to account for modal changes * replace assumed translation key * adds a translated string for sign-out/already signed out * replace expected translation key in spec * back out of translation changes, revise spec expectations to capture emptied fields * refactor session expiration TS to remove redundancy * fix regression for logged-in user timeout * move login page to its own ts file. reduce constant hammering at session status * include a clearInterval when hiding the modal * revise spec for changes to FE script * delete redundant test * branch tests into create and sign in paths * add click cancel to sign in test * remove unneeded attributes and close up refresh and session extend in an if- block * clean up date object, fix overly redundant test setup * change to spec timeout_in * translated text for email field finder * provide calculated value for timeout * remove static expected timeout value * provide session timeout and remove possibly flaky test element
* Omit errors from serialized form response if details present changelog: Internal, Analytics, Omit errors from serialized form response if details present * Update spec expectations on FormResponse * Update SamlRequestValidator specs to drop errors * Update test description accuracy No longer expecting errors keys in these
…#11815) * LG-15294 use the flow policy in state id and address controllers changelog: Internal, In-person proofing, integrates the flow policy into the state id and address controllers
* changelog: Internal, Reporting, stale data check updates
changelog: Internal, Performance, Remove fetch to avoid unnecessary hash allocation
* Remove method_missing usage in Idv::Session - Per comment on #11854, the dynamic access and string manipulation makes these methods a hotspot - Dynamically defining these methods one should hopefully let the JIT optimize this a little better, and lets us use the default implementations for #method_missing and #respond_to_missing? * Use explicit setter methods in specs changelog: Internal, Source code, Optimize dynamic method access
* Update to Ruby 3.4.1 changelog: Internal, Maintenance, Update to Ruby 3.4.1 * Update .rubocop.yml Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com> * Remove pry-doc because it does not support Ruby 3.4 * fix some of the fake analytics spec * update regex for new stacktrace format * use newline as xargs delimiter to avoid issues with files that have spaces in them --------- Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>
* Invert default logging behavior for A/B test changelog: Internal, Analytics, Invert default logging behavior for A/B test * Update analytics service spec expectations * Test more precise bucket value
changelog: Internal, Analytics, Update AnalyticsEventsDocumenter to require exact "**extra"
…11853) * Add persistence option for A/B tests changelog: Internal, A/B Tests, Add persistence option for A/B tests * LG-15560: Enhance A/B tests to support configurable max participants changelog: Internal, A/B Tests, Enhance A/B tests to support configurable max participants * Refactor A/B test report to receive AbTest instance Future support for pulling participant count, having access to configured test max_participants * Include participants status in A/B test report mailer * Fix indentation on multi-line param Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Delete outdated A/B assignments in batches with delete_all See: #11853 (comment) Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Add YARDoc field documentation for new options * Replace automated deletion job with Rake task --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Bumps [phonelib](https://github.com/daddyz/phonelib) from 0.10.3 to 0.10.4. - [Release notes](https://github.com/daddyz/phonelib/releases) - [Changelog](https://github.com/daddyz/phonelib/blob/master/CHANGELOG.md) - [Commits](daddyz/phonelib@v0.10.3...v0.10.4) --- updated-dependencies: - dependency-name: phonelib dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* changelog: User-Facing Improvements, rate limit language, updating language show on doc auth rate limit screen * fixing test to reflect accurate yml variable during view content check * updating language to resolve UX comments * updated logic and tests to use Rails default pluralization support * removing comma as per ux request * reverting changes for idv.failure.sessions.fail_html as it contains different language
changelog: Internal, Analytics, Log errors for profile reactivity password submitted
changelog: Internal, Documentation, Add A/B testing documentation
changelog: Internal, Dependencies, Update dependency to resolve security advisory
LG-15693 - Remove unnecessary filter skips. Also needed spec fixes and a modification to rate limiting. changelog: Internal, Socure, Removed unnecessary before: filter bypasses
* changelog: Internal, Sign in Analyticsg, Tab tracking analytics event added * Use clickable observeable element * include payload as an option * Update observer component * use display list item to fix styling * add click observer component spec * fix aria role * fix lint issue * update spacing * update observer to support nil or improper value * add spec for payload being added * click observer component check * fix analytics event linting and spec * update payload spec for component * fix spec * update lintingg * fix obsever spec * fix linting job * Add A/B testing documentation changelog: Internal, Documentation, Add A/B testing documentation * Revert "Add A/B testing documentation" This reverts commit 9e8c3a2. * update to follow standard naming format * fix to support json * do path instead of url * update spec to use paths instead of url --------- Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
* LG-15456: Source AAMVA requested attributes from request **Why** Requested attributes are for our internal analytics to ensure that the fields sent match any errors we get back. Prior to this change, the requested attributes were sourced from the response body, which meant that regardless of what attributes were requested, we would only know about the attributes that were "seen" and processed by DLDV. Without knowing which fields were actually requested, troubleshooting certain errors is challenging as there would be a mismatch between what was actually sent and how AAMVA processed the request. **How** * Added the logic for generating requested attributes to `Proofing::Aamva::Request::VerificationRequest` as part of creating the request body. * Instead of Set, we use a Hash. Attributes that have a value are coded as 1. Core attributes (e.g., birthdate), which are always requested, are coded as 0 when blank. * Added a constant for storing a map of attributes to XPaths to reduce duplication. * Updated the `Proofing::Aamva::Proofer` to build the request and "normalize" the requested attributes Hash per previous business logic. Future work should consider making a subclass that solely handles building the request body. changelog: Bug Fixes, Analytics, Log correct DLDV requested attributes Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> Co-authored-by: Matt Hinz <matt.hinz@gsa.gov>
* Disable CORS for local development server [skip changelog] * Set allowed origin from env host and port
mitchellhenke
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal