Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-15652 add transaction reference id to analytics #11851

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jmax-gsa
Copy link
Contributor

@jmax-gsa jmax-gsa commented Feb 6, 2025

🎫 Ticket

LG-15652

🛠 Summary of changes

When Socure returns an internal error (i.e., they had a problem on their side), we want to log the transaction id, message, and error code returned by them.

Added transaction id, msg, and error fields from Socure internal errors to the :idv_socure_document_request_submitted and :idv_socure_verification_data_requested analytics events.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Verify that the new docv results job spec "We contact Socure OK, but they return an error" (spec/jobs/socure_docv_results_job_spec.rb:115` correctly checks for the additional attributes in the event log, and passes.
  • Verify that the new docv document capture spec "When Socure throws an internal error" (spec/features/idv/doc_auth/socure_document_capture_spec.rb:577` correctly checks for the additional attributes in the event log, and passes.

@jmax-gsa jmax-gsa force-pushed the jmax/LG-15652-add-transaction-reference-id-to-analytics branch from 161d6b7 to ed22c2e Compare February 7, 2025 16:58
Moved Socure error specs out to their own file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants