Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FormResponse error detail serialization as default behavior #11850

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aduth
Copy link
Contributor

@aduth aduth commented Feb 6, 2025

🛠 Summary of changes

Updates FormResponse to remove the serialize_error_details_only, which is now already treated as the baseline behavior. Additionally, it inverts the assumed default usage of FormResponse from hash-based errors to ActiveModel::Errors-based errors when creating an instance without any errors, resulting in a few more instances where errors is omitted from the resulting serialized hash.

This continues from #11846, and should be the last piece of work in the primary migration away from errors to error_details for typical FormResponse usage with ActiveModel::Errors (not hash) form validation.

📜 Testing Plan

Verify build passes.

changelog: Internal, Analytics, Update FormResponse error detail serialization as default behavior
@aduth aduth requested a review from zachmargolis February 6, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant