Update FormResponse error detail serialization as default behavior #11850
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates
FormResponse
to remove theserialize_error_details_only
, which is now already treated as the baseline behavior. Additionally, it inverts the assumed default usage ofFormResponse
from hash-basederrors
toActiveModel::Errors
-based errors when creating an instance without any errors, resulting in a few more instances whereerrors
is omitted from the resulting serialized hash.This continues from #11846, and should be the last piece of work in the primary migration away from
errors
toerror_details
for typicalFormResponse
usage withActiveModel::Errors
(not hash) form validation.📜 Testing Plan
Verify build passes.