-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dmm/add query to protocol report #11339
Conversation
Can we add a screenshot of the report to the PR? (with fake/sample data as needed)? Helps to put the changes in context |
event: quote([SAML_AUTH_EVENT, OIDC_AUTH_EVENT]), | ||
} | ||
|
||
format(<<~QUERY, params) | ||
fields | ||
name AS protocol, | ||
coalesce(properties.event_properties.service_provider, properties.event_properties.client_id) as issuer | ||
| filter name IN %{event} AND properties.event_properties.success= 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I'd consider calling it "events" (plural) since it's a list
- updating spacing around
success = 1
event: quote([SAML_AUTH_EVENT, OIDC_AUTH_EVENT]), | |
} | |
format(<<~QUERY, params) | |
fields | |
name AS protocol, | |
coalesce(properties.event_properties.service_provider, properties.event_properties.client_id) as issuer | |
| filter name IN %{event} AND properties.event_properties.success= 1 | |
events: quote([SAML_AUTH_EVENT, OIDC_AUTH_EVENT]), | |
} | |
format(<<~QUERY, params) | |
fields | |
name AS protocol, | |
coalesce(properties.event_properties.service_provider, properties.event_properties.client_id) as issuer | |
| filter name IN %{events} AND properties.event_properties.success = 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, i'll fix as long as i'm in here e5d1685
lib/reporting/protocols_report.rb
Outdated
event: quote([SAML_AUTH_EVENT]), | ||
} | ||
|
||
format(<<~QUERY, params) | ||
fields | ||
properties.event_properties.service_provider AS issuer, | ||
properties.event_properties.request_signed = 1 AS signed, | ||
properties.event_properties.request_signed != 1 AS not_signed, | ||
isempty(properties.event_properties.matching_cert_serial) AND signed AS invalid_signature | ||
| filter name IN %{event} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
events (plural)
event: quote([SAML_AUTH_EVENT]), | |
} | |
format(<<~QUERY, params) | |
fields | |
properties.event_properties.service_provider AS issuer, | |
properties.event_properties.request_signed = 1 AS signed, | |
properties.event_properties.request_signed != 1 AS not_signed, | |
isempty(properties.event_properties.matching_cert_serial) AND signed AS invalid_signature | |
| filter name IN %{event} | |
events: quote([SAML_AUTH_EVENT]), | |
} | |
format(<<~QUERY, params) | |
fields | |
properties.event_properties.service_provider AS issuer, | |
properties.event_properties.request_signed = 1 AS signed, | |
properties.event_properties.request_signed != 1 AS not_signed, | |
isempty(properties.event_properties.matching_cert_serial) AND signed AS invalid_signature | |
| filter name IN %{events} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in e5d1685
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Nice work reorganizing the file and cleaning up some headers.
LGTM! (+1 to all of Zach's comments, but none of them are blocking to me.) |
* changelog: Internal, Analytics, Adding facial match issuers query to report
* changelog: Internal, Analytics, Adding facial match issuers query to report
🎫 Ticket
Link to the relevant ticket:
Add facial match issuer query to weekly reports
🛠 Summary of changes
This change
protocols_report.rb
file because it was hard to find things in itNote: The reorganization was very noisy, so I split this PR into two commits. The first commit shows the reorganization, the second commit is the meat of the actual change.