Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-14397: Remove use_fed_domain_class #11326

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Conversation

vrajmohan
Copy link
Member

🎫 Ticket

Link to the relevant ticket:
LG-14397

@vrajmohan vrajmohan requested a review from a team October 8, 2024 21:10
@vrajmohan vrajmohan changed the title Vm remove use fed domain class LG-14397: Remove use fed domain class Oct 8, 2024
@vrajmohan vrajmohan changed the title LG-14397: Remove use fed domain class LG-14397: Remove use_fed_domain_class Oct 8, 2024
changelog: Internal, Configuration, Remove configuration not needed any longer
Make the example descriptions consistent
@vrajmohan vrajmohan force-pushed the vm-remove-use_fed_domain_class branch from dd4dd0c to 051f892 Compare October 8, 2024 22:52
@vrajmohan vrajmohan requested a review from aduth October 9, 2024 14:10
Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JzmCrow
Copy link

JzmCrow commented Oct 10, 2024

LGTM

@vrajmohan vrajmohan merged commit a2e33f7 into main Oct 10, 2024
2 checks passed
@vrajmohan vrajmohan deleted the vm-remove-use_fed_domain_class branch October 10, 2024 13:43
colter-nattrass pushed a commit that referenced this pull request Oct 23, 2024
* LG-14397 Remove use_fed_domain_class config

changelog: Internal, Configuration, Remove configuration not needed any longer

* Fix incorrect example description
* Add test for "email addresses" wihout domains
MrNagoo pushed a commit that referenced this pull request Oct 25, 2024
* LG-14397 Remove use_fed_domain_class config

changelog: Internal, Configuration, Remove configuration not needed any longer

* Fix incorrect example description
* Add test for "email addresses" wihout domains
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants