Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace alt text on capture button with new alt text #11310

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

theabrad
Copy link
Contributor

@theabrad theabrad commented Oct 3, 2024

Changed the alt text to "Photo taken. Submit photo"

🎫 Ticket

Link to the relevant ticket:
LG-14157

🛠 Summary of changes

Update the alt text to "Photo taken. Submit photo" for the green checkmark button after a selfie is taken

📜 Testing Plan

  • Go through IdV on mobile.
  • Get to the selfie step and take a selfie.
  • With a screenreader confirm that the green checkmark says "Photo taken. Submit photo"

Changed the alt text to "Photo taken. Submit photo"
@theabrad theabrad requested review from 2hsieh, jmax-gsa, AShukla-GSA and a team October 3, 2024 19:11
changelog: User-Facing Improvements, Doc Auth, change alt text to selfie green checkmark
Copy link
Contributor

@jmax-gsa jmax-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@2hsieh
Copy link
Member

2hsieh commented Oct 7, 2024

LGTM as well from design side, sorry for delay.

@theabrad theabrad merged commit d4800ea into main Oct 8, 2024
2 checks passed
@theabrad theabrad deleted the abrad-lg-14157-capture-button-alt-txt branch October 8, 2024 16:50
colter-nattrass pushed a commit that referenced this pull request Oct 23, 2024
* Replace alt text on capture button with new alt text

Changed the alt text to "Photo taken. Submit photo"

* add changelog

changelog: User-Facing Improvements, Doc Auth, change alt text to selfie green checkmark
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants