-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lg 13876 continued feature tests #11263
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirbey
reviewed
Sep 19, 2024
amirbey
reviewed
Sep 19, 2024
amirbey
reviewed
Sep 19, 2024
amirbey
reviewed
Sep 19, 2024
amirbey
reviewed
Sep 20, 2024
amirbey
requested changes
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please see my code refactor suggestion ... thanks!
amirbey
requested changes
Sep 21, 2024
app/javascript/packages/document-capture/components/document-capture.tsx
Outdated
Show resolved
Hide resolved
amirbey
reviewed
Sep 25, 2024
amirbey
reviewed
Sep 25, 2024
amirbey
reviewed
Sep 25, 2024
amirbey
reviewed
Sep 25, 2024
app/javascript/packages/document-capture/components/document-side-acuant-capture.tsx
Outdated
Show resolved
Hide resolved
app/javascript/packages/document-capture/components/document-capture-review-issues.tsx
Outdated
Show resolved
Hide resolved
app/javascript/packages/document-capture/components/documents-and-selfie-step.tsx
Outdated
Show resolved
Hide resolved
amirbey
reviewed
Sep 25, 2024
amirbey
reviewed
Sep 25, 2024
amirbey
reviewed
Sep 25, 2024
amirbey
reviewed
Sep 25, 2024
amirbey
reviewed
Sep 25, 2024
amirbey
reviewed
Sep 25, 2024
amirbey
reviewed
Sep 25, 2024
app/javascript/packages/document-capture/components/document-capture.tsx
Outdated
Show resolved
Hide resolved
amirbey
reviewed
Sep 25, 2024
amirbey
reviewed
Sep 26, 2024
amirbey
reviewed
Sep 26, 2024
amirbey
reviewed
Sep 26, 2024
amirbey
reviewed
Sep 26, 2024
amirbey
reviewed
Sep 26, 2024
amirbey
reviewed
Sep 26, 2024
amirbey
reviewed
Sep 26, 2024
…r more code coverage in prep for split doc auth FF enabling
Co-authored-by: Amir Reavis-Bey <amir.reavis-bey@gsa.gov>
AShukla-GSA
force-pushed
the
lg-13876-continued-feature-tests
branch
from
October 1, 2024 14:35
aed8897
to
28a31df
Compare
MrNagoo
pushed a commit
that referenced
this pull request
Oct 3, 2024
* updated tests to passing state * Updated tests to pass split doc auth * Cleaning test * changelog: Upcoming Features, split doc auth, adding feature tests for more code coverage in prep for split doc auth FF enabling * Removed old method * Resolved conflicts and pr comments * Resolving PR comment * Added logic for review step, fixing tests * Update spec/features/idv/analytics_spec.rb Co-authored-by: Amir Reavis-Bey <amir.reavis-bey@gsa.gov> * Updated test names * Improving readability * Removing hardline true * Removing redudant tests * Resolving PR comments * Resolving PR comments * Removing redundant code * Resolving PR comments * Updated doc capture tests * Added check for submission with empty selfie * Added empty file on initial submit check to shared example * Removing unneeded method * Adding hybrid flow selfie capture test from amir's branch * Removed hybrid flow from doc capture and added to hybrid mobile spec * Resolving rebase issues * Fixing Rebase --------- Co-authored-by: Amir Reavis-Bey <amir.reavis-bey@gsa.gov>
colter-nattrass
pushed a commit
that referenced
this pull request
Oct 23, 2024
* updated tests to passing state * Updated tests to pass split doc auth * Cleaning test * changelog: Upcoming Features, split doc auth, adding feature tests for more code coverage in prep for split doc auth FF enabling * Removed old method * Resolved conflicts and pr comments * Resolving PR comment * Added logic for review step, fixing tests * Update spec/features/idv/analytics_spec.rb Co-authored-by: Amir Reavis-Bey <amir.reavis-bey@gsa.gov> * Updated test names * Improving readability * Removing hardline true * Removing redudant tests * Resolving PR comments * Resolving PR comments * Removing redundant code * Resolving PR comments * Updated doc capture tests * Added check for submission with empty selfie * Added empty file on initial submit check to shared example * Removing unneeded method * Adding hybrid flow selfie capture test from amir's branch * Removed hybrid flow from doc capture and added to hybrid mobile spec * Resolving rebase issues * Fixing Rebase --------- Co-authored-by: Amir Reavis-Bey <amir.reavis-bey@gsa.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-13876
🛠 Summary of changes
Adding more feature tests to prep for feature flag enabling