Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lg 13876 continued feature tests #11263

Merged
merged 25 commits into from
Oct 1, 2024
Merged

Conversation

AShukla-GSA
Copy link
Member

🎫 Ticket

Link to the relevant ticket:
LG-13876

🛠 Summary of changes

Adding more feature tests to prep for feature flag enabling

Copy link
Contributor

@amirbey amirbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see my code refactor suggestion ... thanks!

@amirbey amirbey self-requested a review September 20, 2024 20:56
@AShukla-GSA AShukla-GSA force-pushed the lg-13876-continued-feature-tests branch from aed8897 to 28a31df Compare October 1, 2024 14:35
@AShukla-GSA AShukla-GSA merged commit a575965 into main Oct 1, 2024
2 checks passed
@AShukla-GSA AShukla-GSA deleted the lg-13876-continued-feature-tests branch October 1, 2024 17:40
MrNagoo pushed a commit that referenced this pull request Oct 3, 2024
* updated tests to passing state

* Updated tests to pass split doc auth

* Cleaning test

* changelog: Upcoming Features, split doc auth, adding feature tests for more code coverage in prep for split doc auth FF enabling

* Removed old method

* Resolved conflicts and pr comments

* Resolving PR comment

* Added logic for review step, fixing tests

* Update spec/features/idv/analytics_spec.rb

Co-authored-by: Amir Reavis-Bey <amir.reavis-bey@gsa.gov>

* Updated test names

* Improving readability

* Removing hardline true

* Removing redudant tests

* Resolving PR comments

* Resolving PR comments

* Removing redundant code

* Resolving PR comments

* Updated doc capture tests

* Added check for submission with empty selfie

* Added empty file on initial submit check to shared example

* Removing unneeded method

* Adding hybrid flow selfie capture test from amir's branch

* Removed hybrid flow from doc capture and added to hybrid mobile spec

* Resolving rebase issues

* Fixing Rebase

---------

Co-authored-by: Amir Reavis-Bey <amir.reavis-bey@gsa.gov>
colter-nattrass pushed a commit that referenced this pull request Oct 23, 2024
* updated tests to passing state

* Updated tests to pass split doc auth

* Cleaning test

* changelog: Upcoming Features, split doc auth, adding feature tests for more code coverage in prep for split doc auth FF enabling

* Removed old method

* Resolved conflicts and pr comments

* Resolving PR comment

* Added logic for review step, fixing tests

* Update spec/features/idv/analytics_spec.rb

Co-authored-by: Amir Reavis-Bey <amir.reavis-bey@gsa.gov>

* Updated test names

* Improving readability

* Removing hardline true

* Removing redudant tests

* Resolving PR comments

* Resolving PR comments

* Removing redundant code

* Resolving PR comments

* Updated doc capture tests

* Added check for submission with empty selfie

* Added empty file on initial submit check to shared example

* Removing unneeded method

* Adding hybrid flow selfie capture test from amir's branch

* Removed hybrid flow from doc capture and added to hybrid mobile spec

* Resolving rebase issues

* Fixing Rebase

---------

Co-authored-by: Amir Reavis-Bey <amir.reavis-bey@gsa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants