Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-14219: Arrange email as first item in IdV consent screen #11113

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

aduth
Copy link
Contributor

@aduth aduth commented Aug 19, 2024

🎫 Ticket

LG-14219

🛠 Summary of changes

Updates the consent screen to show email address as the first item when consenting to a partner requesting a verified identity.

This brings consistency with how it behaves for IAL1 authentications, and prepares for updates allowing a user to add or change their preferred email address when consenting to share information with a partner (LG-13001).

The changes also include test coverage for expected sort order of keys in the consent screen. This behavior had already been implemented, but there was no test coverage.

📜 Testing Plan

Verify that email address is shown first when consenting to share identity-verified information with a partner:

  1. Have both the IdP and sample application running simultaneously.
  2. Go to http://localhost:9292/?ial=2
  3. Click "Sign in"
  4. Sign in or create an account
  5. When prompted to consent to share information, note order of "Email" attribute as first item

👀 Screenshots

Before After
before after

aduth added 2 commits August 19, 2024 13:50
changelog: User-Facing Improvements, Consent Screen, Arrange email as first item in IdV consent screen
@aduth aduth requested a review from a team August 19, 2024 18:17
@aduth aduth merged commit daab1f8 into main Aug 19, 2024
2 checks passed
@aduth aduth deleted the aduth-lg-14219-email-address-order branch August 19, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants