Enforce YAML normalization for application.yml.default #11106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changelog: Internal, Automated Testing, Enforce YAML normalization for application.yml.default
zachmargolis
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates YAML normalization enforcement to include
application.yml.defaultin enforcement.#10981 enhanced the normalization step to include
application.yml.default, but it wasn't enforced because the pattern that looked for changes after normalization assumed that files would end in.yml. Since this file ends in.yml.default, it wasn't being included in the pattern.📜 Testing Plan
git checkout mainMakefile:git checkout aduth-enforce-app-config-default-normalize -- Makefilelint make_yaml