Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-13245: create enhanced ipp enrollment #10820

Merged
merged 11 commits into from
Jun 17, 2024

Conversation

eileen-nava
Copy link
Contributor

@eileen-nava eileen-nava commented Jun 14, 2024

🎫 Ticket

LG-13245: Consume EIPP Data Supplied by Sinatra App in idp to Create an EIPP Enrollment

🛠 Summary of changes

  • When creating an enhanced ipp enrollment....
    • the call to the USPS API uses the enhanced ipp sponsor_id
    • the call to the USPS API uses the enhanced ipp IALAssuranceLevel
  • When creating an ipp enrollment, there is no change in functionality

📜 Testing Plan

  • Start the identity-oidc sinatra app locally and selected “enhanced in-person proofing” from the “Level of Service” dropdown. Create an account and locally proceed through the ipp flow.
  • On the “Enter your Social Security number”. page, select “Pass” from the For sandbox testing only: Mock device profiling behavior dropdown
  • When you arrive at the barcode page, you should see the enrollment code “3141-59” below the barcode graphic. 🥧 . If you do not see that barcode, please give a shout! Something is wrong.

@gina-yamada
Copy link
Contributor

@eileen-nava Do you have a plan to test this in staging once merged in to confirm that the enrollment is EIPP? (ie How do you know this is an EIPP enrollment? At this stage- is it just a successful enrollment until we complete LG-13577?

@gina-yamada gina-yamada self-requested a review June 17, 2024 19:05
Copy link
Contributor

@gina-yamada gina-yamada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good. Thank for refactoring a few places to take key word args and for updating EIPP to Enhanced IPP.

I observed enrollment code “3141-59” when I created an EIPP enrollment (coming in from Sinatra) on the Ready to Verify view and email. I observed the longer barcode enrollment code on Ready to Verify view and email testing locally.

LGTM! 💯

Screenshot 2024-06-17 at 1 01 53 PM

Screenshot 2024-06-17 at 1 02 59 PM

Screenshot 2024-06-17 at 1 04 35 PM

Screenshot 2024-06-17 at 1 04 43 PM

@eileen-nava eileen-nava merged commit d3c2b08 into main Jun 17, 2024
2 checks passed
@eileen-nava eileen-nava deleted the em/13245-create-eipp-enrollment branch June 17, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants