Refactor proofing_components in AnalyticsSpec #10810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changelog: Internal, Tests, Small refactor to AnalyticsSpec
n1zyy
commented
Jun 12, 2024
spec/features/idv/analytics_spec.rb
Outdated
| let(:base_proofing_components) do | ||
| # rubocop:disable Layout/LineLength | ||
| { document_check: 'mock', document_type: 'state_id', source_check: 'aamva', resolution_check: 'lexis_nexis', threatmetrix: threatmetrix, threatmetrix_review_status: 'pass' } | ||
| # rubocop:enable Layout/LineLength |
There was a problem hiding this comment.
I'd just as soon not disable the LineLength linter, but that's the style in this file, Kyle.
There was a problem hiding this comment.
seems like this part could benefit from being broken out onto separate lines?
There was a problem hiding this comment.
Woot, that was actually my preference but I had my silly rhyme about that being the norm in this file. There's no reason to keep it that way, so update incoming.
| # rubocop:enable Layout/LineLength | ||
| end | ||
| let(:lexis_nexis_address_proofing_components) do | ||
| base_proofing_components.merge(address_check: 'lexis_nexis_address') |
There was a problem hiding this comment.
I thought this was more expressive than repeating the whole thing, even if it's probably a few CPU cycles slower.
zachmargolis
approved these changes
Jun 12, 2024
brandemix
pushed a commit
to brandemix/18F-identity-idp
that referenced
this pull request
Jun 17, 2024
changelog: Internal, Tests, Small refactor to AnalyticsSpec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
No ticket asks for this, but it's done in service of 13120 (and the common good).
🛠 Summary of changes
A change I'm making in 13120 (trying to avoid it autolinking to the LG) requires adding a new parameter to
proofing_components, and changing it in a bajillion places is 😡 not fun.To avoid a wild diff in that PR, I'm putting this up in isolation.