Update missing Chinese translations #10797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchellhenke
force-pushed
the
mitchellhenke/add-missing-translations
branch
from
e176256
to
38028f2
Compare
mitchellhenke
commented
Jun 11, 2024
| @@ -80,27 +80,20 @@ class BaseTask | |||
| { key: 'links.contact', locales: %i[fr] }, # "Contact" is "Contact" in French | |||
| { key: 'saml_idp.auth.error.title', locales: %i[es] }, # "Error" is "Error" in Spanish | |||
| { key: 'simple_form.no', locales: %i[es] }, # "No" is "No" in Spanish | |||
| { key: 'telephony.format_length.six', locales: %i[zh] }, # numeral is not translated | |||
| { key: 'telephony.format_length.ten', locales: %i[zh] }, # numeral is not translated | |||
There was a problem hiding this comment.
These are numerals that we don't need to translate so I've moved them up into this section
mitchellhenke
commented
Jun 11, 2024
| @@ -1560,7 +1560,7 @@ titles.enter_2fa_code.security_code: 输入安全的一次性安全代码 | |||
| titles.failure.information_not_verified: 个人信息未验证 | |||
| titles.failure.phone_verification: 电话号码未验证 | |||
| titles.forget_all_browsers: 忘掉所有浏览器 | |||
| titles.idv.canceled: Identity verification is canceled | |||
| titles.idv.canceled: 身份验证已取消 | |||
There was a problem hiding this comment.
This was not automatically imported because the key was renamed in #10320, but the English content did not change.
mitchellhenke
commented
Jun 11, 2024
| @@ -691,7 +691,7 @@ errors.capture_doc.invalid_link: 链接已过期或有误。 请要求另外一 | |||
| errors.confirm_password_incorrect: 密码不对。 | |||
| errors.doc_auth.consent_form: 在你能继续之前，你必须授予我们你的同意。请在下面的框打勾然后点击继续。 | |||
| errors.doc_auth.doc_type_not_supported_heading: 我们只接受驾照或州政府颁发的 ID。 | |||
| errors.doc_auth.document_capture_canceled: You have canceled uploading photos of your ID on your phone. | |||
| errors.doc_auth.document_capture_canceled: 你已取消了用手机上传身份证件照片。 | |||
There was a problem hiding this comment.
Same situation as https://github.com/18F/identity-idp/pull/10797/files#r1635100867
mitchellhenke
commented
Jun 11, 2024
Comment on lines
-883
to
+884
| forms.webauthn_setup.intro: 使用实体安全密钥为您的 %{app_name} 帐户添加了额外一层安全保障，以防止未经授权的访问。了解有关安全密钥的更多信息 | ||
| forms.webauthn_setup.learn_more: Learn more about security keys | ||
| forms.webauthn_setup.intro: 使用实体安全密钥为您的 %{app_name} 帐户添加了额外一层安全保障，以防止未经授权的访问。 | ||
| forms.webauthn_setup.learn_more: 了解有关安全密钥的更多信息 |
There was a problem hiding this comment.
This was translated as one piece of content in two sentences, but they were later split apart into two separate keys.
zachmargolis
approved these changes
Jun 11, 2024
nickttng
approved these changes
Jun 11, 2024
changelog: Internal, Translations, Update missing Chinese translations
mitchellhenke
force-pushed
the
mitchellhenke/add-missing-translations
branch
from
38028f2
to
88c1ce4
Compare
brandemix
pushed a commit
to brandemix/18F-identity-idp
that referenced
this pull request
Jun 17, 2024
changelog: Internal, Translations, Update missing Chinese translations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
This adds a few translations that were translated but were missed in manual and automatic updates.