Fix internationalization test to fail when there are unused allowed interpolation mismatches #10783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchellhenke
force-pushed
the
mitchellhenke/fail-if-unused-mismatch-locale-keys
branch
from
cc0fb02
to
80efab0
Compare
…nterpolation mismatches changelog: Internal, Internationalization, Fix internationalization test to fail when there are unused allowed interpolation mismatches
mitchellhenke
force-pushed
the
mitchellhenke/fail-if-unused-mismatch-locale-keys
branch
from
80efab0
to
e357793
Compare
zachmargolis
approved these changes
Jun 10, 2024
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
mitchellhenke
deleted the
mitchellhenke/fail-if-unused-mismatch-locale-keys
branch
brandemix
pushed a commit
to brandemix/18F-identity-idp
that referenced
this pull request
Jun 17, 2024
…nterpolation mismatches (18F#10783) * Fix internationalization test to fail when there are unused allowed interpolation mismatches changelog: Internal, Internationalization, Fix internationalization test to fail when there are unused allowed interpolation mismatches * Update spec/i18n_spec.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Update spec/i18n_spec.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * shorten line --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Addresses the comment here #10758 (comment) where we were not failing as expected when we have unused exceptions to mismatched interpolation arguments. I'm not super happy with the logic at this point, but it does seem to work correctly.
The initial run in cc0fb02 is expected to fail.