Clarify instructions for committing optimized fonts and glyphs.txt #10778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changelog: Internal, Documentation, Clarify instructions for committing optimized fonts and glyphs.txt
9 tasks
gina-yamada
approved these changes
Jun 7, 2024
brandemix
pushed a commit
to brandemix/18F-identity-idp
that referenced
this pull request
Jun 17, 2024
…8F#10778) changelog: Internal, Documentation, Clarify instructions for committing optimized fonts and glyphs.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates frontend documentation to clarify language around resolving optimized fonts lint failures.
The instructions included the necessary steps to produce changes to
glyphs.txt, but it was not clear that changes needed to be committed, and particularly changes to both the font files themselves as well asglyphs.txt. These changes seek to clarify this.Related: #10755 (comment)
📜 Testing Plan
Read the updated "Fonts" documentation and verify that it makes sense.