Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename reCAPTCHA mock validator configuration, enable in review apps #10773

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

aduth
Copy link
Member

@aduth aduth commented Jun 6, 2024

🛠 Summary of changes

Renames the reCAPTCHA mock validator configuration name from phone_recaptcha_mock_validator to recaptcha_mock_validator, so that it can be reused for non-phone-specific mock validation. This also aligns to current usage in the otherwise-generic CaptchaSubmitButtonComponent.

It also enables mock validation in the review apps environments, to facilitate testing.

📜 Testing Plan

  1. Go to TBD
  2. Sign in or create an account
  3. Add a phone to your account when presented the opportunity
    • From account dashboard: Click "Add phone number" in sidebar
    • From account creation: Choose "Text or voice message" from MFA selection
  4. Observe field "reCAPTCHA score"
  5. Enter a value above or below 0.5
  6. Submit the page with an international phone number, e.g. +610491570006
  7. Observe:
    • If you entered a value 0.5 or above, you are allowed to pass
    • Otherwise, observe you are shown an error message

👀 Screenshots

image

aduth added 2 commits June 6, 2024 10:23
changelog: Internal, Configuration, Rename reCAPTCHA mock validator configuration
@aduth
Copy link
Member Author

aduth commented Jun 6, 2024

Pretty sure this isn't configured in any deployed environments, but I'll double-check.

@aduth aduth requested a review from a team June 6, 2024 14:29
@aduth
Copy link
Member Author

aduth commented Jun 7, 2024

Pretty sure this isn't configured in any deployed environments, but I'll double-check.

I checked all environments and there was one that needed to be updated (see Slack thread), but otherwise not overridden!

@aduth aduth merged commit 29301b3 into main Jun 7, 2024
2 checks passed
@aduth aduth deleted the aduth-rename-recaptcha-mock-config branch June 7, 2024 14:08
brandemix pushed a commit to brandemix/18F-identity-idp that referenced this pull request Jun 17, 2024
…8F#10773)

* Rename reCAPTCHA mock validator configuration

changelog: Internal, Configuration, Rename reCAPTCHA mock validator configuration

* Enable reCAPTCHA mock validator in review apps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants