log whether "matching cert" is consistent with the bug fix #10765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachmargolis
reviewed
Jun 5, 2024
matthinz
approved these changes
Jun 7, 2024
app/services/analytics_events.rb
Outdated
| @@ -4931,6 +4931,8 @@ def rules_of_use_visit | |||
| # @param [Integer] requested_ial | |||
| # @param [Boolean] request_signed | |||
| # @param [String] matching_cert_serial | |||
| # @option extra [Boolean] encryption_cert_matches_matching_cert If the encryption certificate | |||
There was a problem hiding this comment.
Change to @param and add as a... parameter
| end | ||
|
|
||
| it 'notes that in the analytics event' do | ||
| IdentityLinker.new(user, service_provider).link_identity |
There was a problem hiding this comment.
Mayyyybe look into updating generate_saml_response to do this "and they have a verified email" dance
changelog: Internal, Analytics, add logging for SAML namespace fix
Sgtpluck
force-pushed
the
dmm/log-matching-cert
branch
from
09211df
to
57bfca9
Compare
lmgeorge
approved these changes
Jun 7, 2024
brandemix
pushed a commit
to brandemix/18F-identity-idp
that referenced
this pull request
Jun 17, 2024
* Add logging to determine if bug fix will cause problems with partners * changelog: Internal, Analytics, Add logging for SAML namespace fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
Add SAML request validation matching certificate logging
🛠 Summary of changes
Adds logging so that we can determine which partners, if any, may experience breaking changes when we deploy the code that accurately finds the DigestMethod for SAML request assertions that are not using the
dsnamespace.This change: