LG-13463 | Remove doc_auth_selfie_capture_enabled feature flag #10751
Conversation
It is not being used consistently across environments, but is enabled in production with no plans to turn it off in production.
app/controllers/idv/hybrid_mobile/capture_complete_controller.rb
Outdated
Show resolved
Hide resolved
app/controllers/idv/hybrid_mobile/document_capture_controller.rb
Outdated
Show resolved
Hide resolved
app/controllers/idv/hybrid_mobile/document_capture_controller.rb
Outdated
Show resolved
Hide resolved
This breaks the TrueIdRequestSpec. I will fix that in the AM with a fresh brain.
…nabled feature flag
These tested the now-deleted behavior, in confusing ways.
| @@ -96,18 +92,14 @@ def cancel_establishing_in_person_enrollments | |||
| end | |||
|
|
|||
| def analytics_arguments | |||
| liveness_checking_required = | |||
| FeatureManagement.idv_allow_selfie_check? && | |||
| resolved_authn_context_result.biometric_comparison? | |||
There was a problem hiding this comment.
Per @aduth's excellent earlier comments, I removed these variable assignments that were now x = y and just inlined the y part where it was used. This plays out over the next handful of blocks.
| end | ||
|
|
||
| context 'with liveness_checking_enabled as false' do |
There was a problem hiding this comment.
This diff becomes a little confusing, but tl;dr I removed this context. I kept the content of context 'with liveness_checking_enabled as true' but removed the context block itself because that's now always the case.
| idv_session.selfie_check_required = | ||
| FeatureManagement.idv_allow_selfie_check? && | ||
| resolved_authn_context_result.biometric_comparison? | ||
| idv_session.selfie_check_required = resolved_authn_context_result.biometric_comparison? |
There was a problem hiding this comment.
A note: This is accessed in a lot of places where resolved_authn_context_result is available. I think we could go back and clean those up at some point.
This seems to be set in the session so we can access it in the preconditions block for .step_info for a number of controllers.
…0751) It is not being used consistently across environments, but is enabled in production with no plans to turn it off in production.
🎫 Ticket
Link to the relevant ticket:
LG-13463
🛠 Summary of changes
Based on the Jira story above, this feature, which is enabled in production, has no plans to be disabled, so we should just rip the flag out.