Remove unused configuration keys #10730
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Removes unused configuration keys in
application.yml.default
/IdentityConfig
:acuant_assure_id_password
: Last reference removed in LG-11892: Remove Assure ID integration from the backend #10198acuant_assure_id_subscription_id
: Last reference removed in LG-11892: Remove Assure ID integration from the backend #10198acuant_assure_id_url
: Last reference removed in LG-11892: Remove Assure ID integration from the backend #10198acuant_assure_id_username
: Last reference removed in LG-11892: Remove Assure ID integration from the backend #10198acuant_create_document_timeout
: Last reference removed in LG-11892: Remove Assure ID integration from the backend #10198acuant_facial_match_url
: Last reference removed in LG-11892: Remove Assure ID integration from the backend #10198acuant_get_results_timeout
: Last reference removed in LG-11892: Remove Assure ID integration from the backend #10198acuant_passlive_url
: Last reference removed in LG-11892: Remove Assure ID integration from the backend #10198acuant_timeout
: Last reference removed in LG-11892: Remove Assure ID integration from the backend #10198acuant_upload_image_timeout
: Last reference removed in LG-11892: Remove Assure ID integration from the backend #10198doc_auth_custom_ui_enabled
: Added in LG-11845: feature flag doc_auth_custom_ui_enabled. #9822, never useddoc_auth_s3_request_timeout
: Last reference removed in LG-9611 Remove async document capture code #8377doc_auth_sdk_capture_orientation
: Added in LG-11569: Add feature flag for reorienting SDK capture #9624, never usedvendor_status_acuant
: Last reference removed in LG-11892: Remove Assure ID integration from the backend #10198I was hoping to introduce some automated testing to identify these keys in continuous integration (see 276fbbc), but it didn't work as expected. I'm not sure it could work, since specs are parallelized across many runners, so each individual runner doesn't have access to a global shared pool of tracked calls to config methods.
Instead, I put together a bash script to identify unused keys:
📜 Testing Plan
Verify there are no references to the removed configuration keys.