Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify SpHandoffBounce classes #10720

Merged
merged 3 commits into from
May 29, 2024
Merged

Conversation

zachmargolis
Copy link
Contributor

Why: Combines two separate one-method classes into one class, adds unit test coverage

**Why**: Combines two separate one-method classes into one class,
adds unit test coverage

changelog: Internal, Source code, Unify related classes
@zachmargolis zachmargolis requested a review from a team May 29, 2024 21:39
@zachmargolis zachmargolis merged commit c794786 into main May 29, 2024
2 checks passed
@zachmargolis zachmargolis deleted the margolis-unify-sp-handoff-bounce branch May 29, 2024 23:14
zachmargolis added a commit that referenced this pull request May 31, 2024
- Accidentally forgot to commit as part of #10720

changelog: Internal, Source code, Increase unit test coverage
zachmargolis added a commit that referenced this pull request May 31, 2024
- Accidentally forgot to commit as part of #10720

changelog: Internal, Source code, Increase unit test coverage
colter-nattrass pushed a commit that referenced this pull request Jun 3, 2024
**Why**: Combines two separate one-method classes into one class,
adds unit test coverage

changelog: Internal, Source code, Unify related classes
colter-nattrass pushed a commit that referenced this pull request Jun 3, 2024
- Accidentally forgot to commit as part of #10720

changelog: Internal, Source code, Increase unit test coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants