LG-13170: add 5 digit zipcode to analytics #10696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirbey
changed the title
| @@ -1127,6 +1127,7 @@ def idv_doc_auth_submitted_image_upload_form( | |||
| # @param [Hash] portrait_match_results | |||
| # @param [Hash] image_metrics | |||
| # @param [Boolean] address_line2_present | |||
| # @param [String] zip_code | |||
There was a problem hiding this comment.
looks like we have both zip_code and zipcode in our codebase 😭 but zipcode is more common:
identity-idp:main> git grep zip_code -- 'app' | wc -l
28
identity-idp:main> git grep zipcode -- 'app' | wc -l
119
Suggested change
| # @param [String] zip_code | |
| # @param [String] zipcode |
There was a problem hiding this comment.
snakecasing words seems to be consistent in our analytics .... are you suggesting making the argument zipcode and then in the body:
zip_code: zipcode,
There was a problem hiding this comment.
no I was suggesting zipcode (no underscore) everywhere in the PR
zachmargolis
approved these changes
May 24, 2024
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
amirbey
force-pushed
the
timnit/LG-13170-log-5digit-zipcode
branch
from
3793183
to
9c52553
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-13170
🛠 Summary of changes
📜 Testing Plan