LG-13201: DoS Translations - Gengo translations - Sprint 311 differences #10669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changelog: User-facing Improvements, Authentication, translation updates from previous sprint
jmdembe
changed the title
jmdembe
commented
May 21, 2024
config/locales/zh.yml
Outdated
| user_mailer.new_device_sign_in_attempts.events.sign_in_unsuccessful_2fa: 身份证实失败 | ||
| user_mailer.new_device_sign_in_attempts.new_sign_in_from: 新登录可能是在 %{location} | ||
| user_mailer.new_device_sign_in_before_2fa.info_p1_html.one: Your %{app_name} email and password were used to sign in from a new device but <strong>身份证实失败</strong>. | ||
| user_mailer.new_device_sign_in_before_2fa.info_p1_html.other: Your %{app_name} email and password were used to sign in from a new device but <strong>身份证实失败%{count}次</strong>. |
There was a problem hiding this comment.
Per the Slack conversation, I need the complete text before making the PR ready for review.
jmdembe
commented
May 21, 2024
config/locales/zh.yml
Outdated
| user_mailer.new_device_sign_in_attempts.new_sign_in_from: 新登录可能是在 %{location} | ||
| user_mailer.new_device_sign_in_before_2fa.info_p1_html.one: Your %{app_name} email and password were used to sign in from a new device but <strong>身份证实失败</strong>. | ||
| user_mailer.new_device_sign_in_before_2fa.info_p1_html.other: Your %{app_name} email and password were used to sign in from a new device but <strong>身份证实失败%{count}次</strong>. | ||
| user_mailer.new_device_sign_in_before_2fa.info_p1_html.zero: Your %{app_name} email and password were used to sign in from a new device but <strong>身份证实失败</strong>. |
There was a problem hiding this comment.
Same comment as above.
jmdembe
force-pushed
the
jd/LG-13201-dos-translations
branch
from
050252d
to
40ea7a2
Compare
jmdembe
force-pushed
the
jd/LG-13201-dos-translations
branch
from
40ea7a2
to
44cbf9b
Compare
jmdembe
force-pushed
the
jd/LG-13201-dos-translations
branch
from
e443065
to
3ed2a1d
Compare
mdiarra3
approved these changes
May 24, 2024
aduth
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-13201: DoS Translations - Gengo translation - Sprint 311 differences
🛠 Summary of changes
This PR updates translations from Gengo --> DoS and add provided Chinese translations