Deploy RC 370 to Production #10386
Merged
Deploy RC 370 to Production #10386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changelog: Internal, Configuration, Improve CSV parsing for configuration values Co-authored-by: Zach Margolis <zachary.margolis@gsa.gov>
changelog: Internal, AB Tests, Remove Doc Auth Fallbacks
…10314) * LG-12294: Send aggregated email notification for new device sign-in changelog: Upcoming Features, Sign In, Send single aggregated email notification for new device sign-in * Localize to geocoded timezone if available * Move event grouping logic to mailer class See: https://github.com/18F/identity-idp/pull/10314/files#r1540041239 Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Memoize user object for user mailer preview * Use EasternTimePresenter for timestamp * Linkify authentication methods * Update "potentially located in" language https://gsa-tts.slack.com/archives/C05R6BLVAQG/p1711549883747499?thread_ts=1711476471.048729&cid=C05R6BLVAQG * Add English string for sign_in_unsuccessful_2fa event * Track event sign_in_unsuccessful_2fa * Incorporate "failed X times" text * Revert to uswds-core Original change was trying to resolve Sass error, fixed by reinstalling dependencies. Importing uswds-core ensures other overrides defined in stylesheets/_uswds-core.scss are applied * Split separate mailers for sign in before/after 2fa The two content are more distinct than initially expected See: https://github.com/18F/identity-idp/pull/10314/files#r1548593213 * Annotate used dynamic strings * Add translations * Interpolate app_name * Normalize YAML * Sync preview name with mailer name * Update French translation for failed times --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
… speed (#10359) changelog: Internal, Testing, Consolidate identity verification accessibility tests to improve test speed
* Enable MutableConstants rubocop rule changelog: Internal, Performance, Freeze constants --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* Update accessibility checkers to latest version * Incorporate latest WCAG 2 AA (ideally 2.2) Section 508 is redundant with WCAG 2 AA: "The Revised 508 Standards incorporate by reference the WCAG 2.0 Level AA Success Criteria, and apply the WCAG 2.0 Level AA success criteria and conformance requirements to both web and non-web electronic content." https://www.section508.gov/develop/applicability-conformance/ * Check duplicate element IDs in accessibility tests changelog: Internal, Automated Testing, Check duplicate element IDs in accessibility tests * Temporary: Demonstrate failure * Revert "Temporary: Demonstrate failure" This reverts commit 12ae6e4. * Fix duplicate form ID on how to verify page * Check WCAG 2.2 AA The intent of the previous code was "latest 2.x", meaning 2.2 currently. In reality, "wcag2aa" means "2.0" specifically. Ref: https://github.com/dequelabs/axe-core/blob/master/doc/API.md#axe-core-tags
This fixes log writing failures of the form 'log writing failed. "\xB5" from ASCII-8BIT to UTF-8'. changelog: Internal, Logging, Update dependency
changelog: Internal, Automated Testing, Fix manifest cache for local JavaScript feature tests
Update security key setup page changelog: User-Facing Improvements, Authentication, Update security key setup form
* Add short-term rate limit as delay between OTP sends changelog: Internal, Rate Limiting, Add short-term rate limit as delay between OTP sends * add analytics * use have_logged_event
* changelog: Internal, Fraud Detection Prevention, Time interval worker for aggregation of new device emails * add device sign in datetime to user table. add worker and feature-bound changes to new device alert class * add spec for create_new_device_alert, feature checking for existing device tests * fix line too long and misalignment lint errors * make function name clearer. changes to spec * publish config changes * apply Feature logic to disavowal spec. slight change to new test * fix db table naming, remove unneeded feature_management method, update test behavior * change to new device spec * add email counter to alert and testing * reload the db value * replace corrected date field suffix * rebase conflict changed schema * restructure test to remove if-feature * move email function to alert service, add feature check to job runner, standardize feature name, enhance tests * rebase to add frozen_string_literal, move appropriate functions over to alert_user_about... service, add test case * remove assumed email send function from test * removes frozen_string_literal from spec files I had added to * revise db migration, optimize query at device alert, remove unneeded spec * remove no-longer needed include * include needed for send_alert(user) method * make referenced method use explicit syntax
* fix: Gemfile & Gemfile.lock to reduce vulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-RUBY-ROTP-6457147 * Reset Ruby version in lockfile * Add changelog changelog: Internal, Dependencies, Update dependencies to resolve security advisories --------- Co-authored-by: snyk-bot <snyk-bot@snyk.io> Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
Bumps [libphonenumber-js](https://gitlab.com/catamphetamine/libphonenumber-js) from 1.10.59 to 1.10.60. - [Changelog](https://gitlab.com/catamphetamine/libphonenumber-js/blob/master/CHANGELOG.md) - [Commits](https://gitlab.com/catamphetamine/libphonenumber-js/compare/v1.10.59...v1.10.60) --- updated-dependencies: - dependency-name: libphonenumber-js dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Update disavowed event lookup to load one record changelog: Internal, Database, Optimize event disavowal query to load single record into memory * Memoize nil event value Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
…10375) * Update component documentation to describe stylesheet auto-loading changelog: Internal, Documentation, Update component document to describe stylesheet auto-loading * Consistent period
- CSS has named transitions "ease-in-out" instead
of having to hardcode bezier control points ("0 .37 0 .86")
- Supports CSS reduced motion query to let us modify (remove)
animation based on user preferences
changelog: User-facing Improvements, Accessibility, Add support for reduced motion for security key image animation
* Remove template and use #call
Co-authored-by: Andrew Duthie <aduth@users.noreply.github.com>
* Add support for tag_options
* Remove explicit height/width to scale with screen
* spec to check for HTML-safe regressions
---------
Co-authored-by: Andrew Duthie <aduth@users.noreply.github.com>
* build-sass: Add verbose flag to output build files * build-sass: Resolve error paths from compiler file changelog: Internal, Build Tooling, Fix Sass compilation rebuild after error * Add CHANGELOG.md entry
aduth
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Internal
Upcoming Features