Deploy RC 363 to Production #10234
Merged
Deploy RC 363 to Production #10234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* changelog: Bug Fixes, Accessibility, Safari use of VoiceOver reading alt=null images * add ability to check for role in svg * change role from 'img' to 'presentation' * reset role to img * revert test for svg role * fix lint * add skipping method to axe_clean violation test * make axe exclude more specific * add comment explaining exclude matcher
* Upgrade Login.gov Design System to v9.0 * Add changelog changelog: Internal, Dependencies, Update dependencies to latest versions
changelog: Internal, Code Quality, Remove unnecessary background styles from language picker
changelog: Bug Fixes, PIV/CAC, Consistently clear PIV session detail after deletion
* Note the places for addition * Add FE logging and fix existing tests * changelog: Internal, In-Person Proofing, Add FE logging for liveness_check_required * test commit * Add to FE logs * Add additional FE events * Remove unnessecary change - liveness_checking_required is already included in response * Add `liveness_checking_required` to more FE events * Add new value to tests * Fix missing argument * Remove duplicate param doc * Lint fixes * Use the new SelfieCaptureContext * Update events to include "image added" events * Document events to fix lint problem
changelog: Internal, Automated Testing, Improve reliability of automated tests
* Remove legacy TOTP deletion routes changelog: Internal, Code Quality, Remove legacy MFA management route code * Remove unused find_form
* Remove legacy PIV/CAC deletion routes changelog: Internal, Code Quality, Remove legacy MFA management route code * Remove unused find_form
… for SAML (#10224) In #10178 we added the ability for SAML service providers to make a request with a vector of trust in the AuthnContext. When a SAML SP does this the vector of trust that is used for the authentication transaction should be reflected to the SP in the SAML response. The authentication context appears in 2 places in the SAML request: 1. In the authn context for the entire transaction: ```xml <AuthnStatement AuthnInstant="2024-01-01T00:00:00" SessionIndex="_abc-123-def-456"> <AuthnContext> <AuthnContextClassRef>A1.B2.C3</AuthnContextClassRef> </AuthnContext> </AuthnStatement> ``` 2. In the attribute statement. With ACR values these appeared as seperated AAL and IAL nodes. For VTRs they appear in a single VTR node: ```xml <AttributeStatement> <!-- ... --> <Attribute Name="vot" NameFormat="urn:oasis:names:tc:SAML:2.0:attrname-format:uri" FriendlyName="vot"> <AttributeValue>A1.B2.C3</AttributeValue> </Attribute> </AttributeStatement> ``` Making the VoT appear like this required changes in 2 places: 1. In the SAML controller the correct `authn_context` value was passed to the `#encode_response` method. This is a method from the `18f/saml_idp` gem which is overriden in `SamlIdpController`. 2. The `AttributeAsserter` was modified to recognized a VTR request and add the correct values to the `AttributeStatement` node in the SAML response. changelog: Internal, SAML, VTR support was added to SAML Response
changelog: User-Facing Improvements, Doc Auth, Update selfie hint text translations.
Updated with new text, and pulled out a new presenter WelcomeScreenPresenter. changelog: Upcoming features,biometrics,Getting started screen for step-up selfies
Changed oidc user info endpoint to include vot information when requested. changelog: Upcoming features,VoT,Added Vot to oidc user info --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* fix session result bug when selfie is not requested [skip changelog] * selfie_status not_processed when selfie has not been requested * define success for session result stub * update test for document capture session result success? alias * rename liveness_enabled to match trueIDrespones arg name * happy linting * test that success? method returns success attribute value * restore docauth mock selfie_status now that TrueIDRespnse#selfie_status only stores selfie_result when present and requested * update comment for selfie_stauts return value
zachmargolis
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal
Upcoming Features