[LG-12819] Optimized proofing query (#11083)

* updated proofing query \n changelog Internal, Proofing Metrics, optimized proofing query * Update spec/lib/reporting/fraud_metrics_lg99_report_spec.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * changelog Internal, Proofing Metrics, optimized proofing query * changelog: Internal, Proofing Metrics, optimized proofing query --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
18F · Aug 15, 2024 · 6ab79b3 · 6ab79b3
1 parent 604aa3c
commit 6ab79b3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/lib/reporting/fraud_metrics_lg99_report.rb b/lib/reporting/fraud_metrics_lg99_report.rb
@@ -145,17 +145,16 @@ def user_days_to_suspension_avg
     end
 
     def user_days_proofed_to_suspension_avg
-      user_data = User.where(uuid: data[Events::SUSPENDED_USERS]).joins(:profiles).
-        where.not(profiles: { verified_at: nil }).
-        group('users.id').
+      user_data = User.where(uuid: data[Events::SUSPENDED_USERS]).includes(:profiles).
+        merge(Profile.active).
         pluck(
-          'MAX(profiles.verified_at)',
+          :activated_at,
           :suspended_at,
         )
 
       return 'n/a' if user_data.empty?
 
-      difference = user_data.map { |profiled_at, suspended_at| suspended_at - profiled_at }
+      difference = user_data.map { |activated_at, suspended_at| suspended_at - activated_at }
       (difference.sum / difference.size).seconds.in_days.round(2)
     end
 

diff --git a/spec/lib/reporting/fraud_metrics_lg99_report_spec.rb b/spec/lib/reporting/fraud_metrics_lg99_report_spec.rb
@@ -52,7 +52,7 @@
         { 'user_id' => 'user7', 'name' => 'User Suspension: Suspended' },
       ],
     )
-    user7&.profiles&.verified&.last&.update(created_at: 1.day.ago, verified_at: 1.day.ago)
+    user7.profiles.verified.last.update(created_at: 1.day.ago, activated_at: 1.day.ago) if user7
   end
 
   describe '#lg99_metrics_table' do