Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data.gov - updating dns #567

Merged
merged 5 commits into from
Feb 2, 2022
Merged

data.gov - updating dns #567

merged 5 commits into from
Feb 2, 2022

Conversation

robert-bryson
Copy link
Contributor

@robert-bryson robert-bryson commented Jan 28, 2022

Related to GSA/data.gov#1001

This PR configures data.gov DNS to use 18f/dns in the near future.

In order to configure DNSSEC, the aws_route53_hosted_zone_dnssec resource is need from terraform-provider-aws. It was introduced in 3.31.0 so this PR updates the version currently used by 18f/dns (3.30.0) one minor version.

3.30.0 was released in March 2021, the current version is 3.74.0.


Data.gov is not a new site, so I believe the section below is not relevant.

@robert-bryson
Copy link
Contributor Author

@robert-bryson robert-bryson marked this pull request as ready for review February 1, 2022 17:26
Copy link
Member

@JJediny JJediny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes and minor upgrade look good. @mogul ready to merge?

@mogul
Copy link
Contributor

mogul commented Feb 2, 2022

@JJediny yup, let's do it.

@JJediny JJediny merged commit 7e261cb into 18F:main Feb 2, 2022
@davemcorwin
Copy link
Contributor

@robert-bryson
Copy link
Contributor Author

robert-bryson commented Feb 3, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants