Skip to content
This repository has been archived by the owner on Dec 6, 2017. It is now read-only.

Test endpoints #11

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Test endpoints #11

wants to merge 6 commits into from

Conversation

mgwalker
Copy link
Member

@mgwalker mgwalker commented Apr 12, 2017

Makes some fixes to the Swagger (it wasn't strictly valid), but primarily adds tests to hit the API endpoints via HTTP calls to make sure what we're getting back is valid according to the Swagger spec and that we're getting back the response codes we expect.

Still needs...
- [ ] validate responses for defined non-success conditions (e.g., 404 on /client/dcn)

  • For that 404, there's no return value specified. The 404 is the whole thing.

Verified

This commit was signed with the committer’s verified signature.
mgwalker Greg Walker

Verified

This commit was signed with the committer’s verified signature.
mgwalker Greg Walker
…dencies there

Verified

This commit was signed with the committer’s verified signature.
mgwalker Greg Walker
… of 404; associated tests

Verified

This commit was signed with the committer’s verified signature.
mgwalker Greg Walker

Verified

This commit was signed with the committer’s verified signature.
mgwalker Greg Walker

Verified

This commit was signed with the committer’s verified signature.
mgwalker Greg Walker
@codecov-io
Copy link

Codecov Report

Merging #11 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           develop    #11   +/-   ##
======================================
  Coverage      100%   100%           
======================================
  Files            8      8           
  Lines           79     81    +2     
  Branches         9     10    +1     
======================================
+ Hits            79     81    +2
Impacted Files Coverage Δ
api/middleware/cors.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47dd542...3918165. Read the comment docs.

@mgwalker mgwalker changed the title [WIP] Test endpoints Test endpoints Apr 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants