Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing Refactoring of main #159

Merged
merged 11 commits into from
Apr 30, 2022
Merged

Testing Refactoring of main #159

merged 11 commits into from
Apr 30, 2022

Conversation

1337-server
Copy link
Owner

@1337-server 1337-server commented Apr 25, 2022

  • Work around added for Track 99 protection (ARM will now rip them using MakeMKV)

  • All the arm main.py sections, that relate to dvd/blu-ray moved to its own file.

  • arm.ripper now uses the arm.ui.constants file

  • jobs are now back(mostly) to using the saved config from the database

  • job_dupe_check now only returns 1 value (True|False)

  • Added error message to message div in /database

  • More fstrings, comments, etc.


Needs more testing/work, only tested on Ubuntu 20.04 LTS

- ARM will now rip them using MakeMKV

All the arm main.py sections, that relate to dvd/blu-ray moved to its own file.

arm.ripper now uses the arm.ui.constants file

jobs are now back(mostly) to using the saved config from the database

job_dupe_check now only returns 1 value (True|False)

More fstrings, comments, etc
@1337-server 1337-server changed the title Testing Testing Refactoring of main Apr 25, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@1337-server 1337-server self-assigned this Apr 30, 2022
@1337-server 1337-server added bug Something isn't working enhancement New feature or request CodeClimate Automatic Checking labels Apr 30, 2022
@1337-server 1337-server marked this pull request as ready for review April 30, 2022 05:16
@1337-server 1337-server merged commit 2dfb08e into v2_devel Apr 30, 2022
@1337-server 1337-server deleted the testing branch April 30, 2022 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CodeClimate Automatic Checking enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant