Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 ARMui ripper settings using "" will break the arm config #201

Closed
4 tasks done
1337-server opened this issue Jul 5, 2022 · 0 comments · Fixed by #204
Closed
4 tasks done

🐛 ARMui ripper settings using "" will break the arm config #201

1337-server opened this issue Jul 5, 2022 · 0 comments · Fixed by #204
Labels
bug Something isn't working Fixed

Comments

@1337-server
Copy link
Owner

Is there an existing issue for this?

  • I have searched the existing issues

I have checked the wiki

  • I have searched the wiki for this problem

Does this issue exist in the latest version?

  • I'm using the latest release

Describe the bug?

Using quotes " in any of the settings on the ripper settings tab will break the install. As they aren't escaped meaning when saved it breaks the ARMripper run command and ARMui

To Reproduce

  1. Use this as subtitle settings
    -s "1,2,3,4,5,6" --audio-lang-list eng --audio-copy-mask ac3,dts,dtshd --audio-fallback ffac3
  2. Save the config
  3. ARM will break - armui and ripper fails

What OS are you seeing the problem on?

all

ARM Release Version or Git hash (You can find this in the arm settings page)

v2.6.3a

Expected behavior?

For arm to escape quotes.
This might be a security issue that would allow anyone to run bash code if the end user doesn't require login.

Relevant log output

N/A

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@1337-server 1337-server added the bug Something isn't working label Jul 5, 2022
1337-server added a commit that referenced this issue Jul 6, 2022
@1337-server 1337-server mentioned this issue Jul 6, 2022
17 tasks
@1337-server 1337-server linked a pull request Jul 6, 2022 that will close this issue
17 tasks
1337-server added a commit that referenced this issue Jul 6, 2022
Fix for #201
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant