Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why res_manipulator returns enc_b + diff rather than enc_a + diff? #5

Closed
kkjh0723 opened this issue Nov 24, 2018 · 3 comments
Closed

Comments

@kkjh0723
Copy link

kkjh0723 commented Nov 24, 2018

In modules.py, I found that res_manipulator returns enc_b + diff rather than enc_a + diff (line 38).
According to the eq. 3 in the paper, isn't the later correct?
I might understand wrong...

@12dmodel
Copy link
Owner

12dmodel commented Nov 26, 2018 via email

@kkjh0723
Copy link
Author

Thank you. I understand.

@ZhengPeng7
Copy link

To be very serious, it should only be enc_b + diff.
Suppose we have frame _ A/B/C/M in the given coco dataset, there is color perturbation between A and M. The perturbation was designed as a regularization for extracting motion better, instead of aiming to output an additional perturbation.
And if you check the amplification, enc_b + diff is also the one should be chosen.

link to this confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants