-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
why res_manipulator returns enc_b + diff rather than enc_a + diff? #5
Comments
It's possible we are using different definition of alpha in the code and in
the paper. When we return enc_b + diff, alpha = 0 means no change (and -1
for attenuated motion), while when we return enc_a + diff, this means alpha
= 1 means no change (and 0 for motion attenuated). In my experience there
is no real difference between the two, when alpha is large (say >10), the
difference doesn't seem to be noticeable.
I will double check these when I have time, thanks for pointing that out.
…On Fri, Nov 23, 2018 at 11:06 PM Jinhyung ***@***.***> wrote:
In modules.py, I found that res_manipulator returns enc_b + diff rather
than enc_a + diff (line 38).
According to the eq. 3 in the paper, isn't the later correct?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#5>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABtIV_kh252_5rfzei8Rkpepa40gn4Gxks5uyMWrgaJpZM4YxQ0Y>
.
|
Thank you. I understand. |
To be very serious, it should only be enc_b + diff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In modules.py, I found that res_manipulator returns enc_b + diff rather than enc_a + diff (line 38).
According to the eq. 3 in the paper, isn't the later correct?
I might understand wrong...
The text was updated successfully, but these errors were encountered: