Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/188 PHP Version Check #200

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Fix/188 PHP Version Check #200

merged 1 commit into from
Sep 20, 2023

Conversation

bmarshall511
Copy link
Contributor

Description of the Change

Added a minimum PHP version check for 7.4.

Closes #188

How to test the Change

  1. Spin up the site with a version of PHP below 7.4
  2. Verify an admin notice has been added alerting the user of the failed check

Changelog Entry

Added - >=PHP 7.4 version check

Credits

Props @bmarshall511

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.

@bmarshall511 bmarshall511 added the needs:code-review This requires code review. label Sep 18, 2023
@bmarshall511 bmarshall511 self-assigned this Sep 18, 2023
@bmarshall511 bmarshall511 requested a review from a team as a code owner September 18, 2023 14:34
@bmarshall511 bmarshall511 requested review from iamdharmesh and removed request for a team September 18, 2023 14:34
@jeffpaul jeffpaul added this to the 4.4.0 milestone Sep 18, 2023
iamdharmesh
iamdharmesh approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeffpaul jeffpaul merged commit e262645 into develop Sep 20, 2023
@jeffpaul jeffpaul deleted the fix/188-php-version-check branch September 20, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamdharmesh iamdharmesh iamdharmesh approved these changes

@rickalee rickalee Awaiting requested review from rickalee rickalee is a code owner

Assignees

@bmarshall511 bmarshall511

Labels
needs:code-review This requires code review.
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

Add PHP checks
3 participants
@bmarshall511 @iamdharmesh @jeffpaul