Ensure all Podcast terms show in the editor sidebar #268
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
As reported in #267, only 10 Podcast terms currently show in the Block Editor sidebar panel. In looking into this, seems we introduced a custom component to render these terms in #232, in order to have a nicer experience when adding new Podcasts from the sidebar.
The code for this uses
getEntityRecords
to get the Podcasting terms. The problem here is by default this will only query for the last 10 items. For sites that have more than 10 Podcasting terms set up, not all of those will end up showing.This PR fixes that by adding some default query params to the
getEntityRecords
call to ensure we return more terms. This matches what we are doing inassets/js/term-selector/hierarchichal-term-selector.js
.Closes #267
How to test the change
develop
branchChangelog Entry
Credits
Props @dkotter, @channchetra
Checklist: