Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all Podcast terms show in the editor sidebar #268

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Conversation

dkotter
Copy link
Collaborator

@dkotter dkotter commented Jan 10, 2024

Description of the Change

As reported in #267, only 10 Podcast terms currently show in the Block Editor sidebar panel. In looking into this, seems we introduced a custom component to render these terms in #232, in order to have a nicer experience when adding new Podcasts from the sidebar.

The code for this uses getEntityRecords to get the Podcasting terms. The problem here is by default this will only query for the last 10 items. For sites that have more than 10 Podcasting terms set up, not all of those will end up showing.

This PR fixes that by adding some default query params to the getEntityRecords call to ensure we return more terms. This matches what we are doing in assets/js/term-selector/hierarchichal-term-selector.js.

Closes #267

How to test the change

  1. Check out the develop branch
  2. Add at least 11 Podcast terms
  3. Go to a post and notice that only 10 Podcast terms are showing
  4. Checkout this PR
  5. Go to a post and notice all Podcast terms are now showing

Changelog Entry

Fixed - Ensure we show all Podcasting terms in the Block Editor sidebar

Credits

Props @dkotter, @channchetra

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

@dkotter dkotter added this to the 1.7.0 milestone Jan 10, 2024
@dkotter dkotter self-assigned this Jan 10, 2024
@dkotter dkotter requested a review from a team as a code owner January 10, 2024 16:50
@dkotter dkotter requested review from Sidsector9 and removed request for a team January 10, 2024 16:50
@github-actions github-actions bot added the needs:code-review This requires code review. label Jan 10, 2024
Copy link
Member

@Sidsector9 Sidsector9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and tests well 👍

@Sidsector9 Sidsector9 merged commit 566573e into develop Jan 11, 2024
13 checks passed
@Sidsector9 Sidsector9 deleted the fix/267 branch January 11, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with Displaying All Podcasts in Gutenberg Editor on WordPress 6.4.2
2 participants