-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/154: add a Podcast Platforms Block #241
Conversation
@iamdharmesh this is ready for your review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR and great work here @Sidsector9. Just added 2-3 minor notes to discuss other wise all good.
Thanks
'type' => 'platform_fields', | ||
), | ||
array( | ||
'slug' => 'podcasting_icon_theme', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick:
I think keeping the icon theme option at block level is more user-friendly. Not a major issue, but love to hear your thoughts on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iamdharmesh that's a good idea, but something we can iteratively implement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure @Sidsector9, maybe we should create a follow-up issue for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes @Sidsector9, LGTM!
Closes #154
Description of the Change
This PR adds the Podcast Platforms block.
Podcasting Platforms block
Podcasting Platforms settings
Verification Process
Checklist:
Changelog Entry
Credits
Props @jeffpaul @Sidsector9