Replace custom commands with @10up/cypress-wp-utils #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinhtungdu
changed the title
dinhtungdu
changed the title
cadic
suggested changes
Apr 12, 2022
There was a problem hiding this comment.
@dinhtungdu thank you for this great update!
I left couple questions about other commands we can potentially replace.
| }); | ||
|
|
||
| it('Can activate plugin if it is deactivated', () => { | ||
| cy.visit('/wp-admin/plugins.php'); |
There was a problem hiding this comment.
Could we use cy.activatePlugin() and cy.deactivatePlugin() here?
| cy.visitAdminPage( | ||
| 'edit-tags.php?taxonomy=podcasting_podcasts&podcasts=true' | ||
| it('Can delete all taxonomies', () => { | ||
| cy.visit( |
There was a problem hiding this comment.
Could we shortcut this with cy.deleteAllTerms('podcasting_podcasts')?
|
@cadic Thanks for the review. I updated the PR per your suggestion. Please take another look! |
cadic
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR updates the Cypress test suite to use
@10up/cypress-wp-utilsinstead of custom commands. This is currently blocked by 10up/cypress-wp-utils#51.Closes #161
Verification Process
See tests pass on both local and GH Actions.
Checklist:
Changelog Entry
Credits
Props @dinhtungdu