Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CODEOWNERS #156

Merged
merged 1 commit into from
Mar 8, 2022
Merged

Create CODEOWNERS #156

merged 1 commit into from
Mar 8, 2022

Conversation

jeffpaul
Copy link
Member

@jeffpaul jeffpaul commented Mar 8, 2022

Description of the Change

This PR adds a CODEOWNERS file in the .github directory to specific specific people to set as Reviewers on future Pull Requests. In general, it sets @cadic (as the primary project maintainer) as the default Reviewer. Certain directories/files are set to @jeffpaul as Reviewer to ensure that any impacting changes to how the project is published on GitHub and WordPress.org get appropriate review.

After reviewing/merging this in and testing to ensure expected default Reviewers are set within this repo, I'll look to replicate this change to our other repos and document within our Open Source Best Practices.

Alternate Designs

n/a

Possible Drawbacks

Verification Process

Reviewed GitHub documentation and public examples to ensure this is set correctly, as well as ensured that repo settings are updated to ensure future PRs take impact from the new CODEOWNERS file.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Added - Default Pull Request Reviewers via CODEOWNERS file.

Credits

Props @jeffpaul.

@jeffpaul jeffpaul added this to the 1.3.0 milestone Mar 8, 2022
@jeffpaul jeffpaul self-assigned this Mar 8, 2022
@jeffpaul jeffpaul requested a review from cadic March 8, 2022 03:44
Copy link
Contributor

@cadic cadic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cadic cadic merged commit ecc606d into develop Mar 8, 2022
@cadic cadic deleted the add/codeowners branch March 8, 2022 07:39
@cadic cadic modified the milestones: 1.3.0, 1.2.3 Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants