-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP8 compatibility #150
PHP8 compatibility #150
Conversation
readme.txt
Outdated
@@ -3,7 +3,7 @@ Contributors: 10up, helen, adamsilverstein, jakemgold | |||
Tags: simple podcasting, podcasting, podcast, apple podcasts, episode, gutenberg, blocks, block | |||
Requires at least: 4.6 | |||
Tested up to: 5.9 | |||
Requires PHP: 5.3 | |||
Requires PHP: 7.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious why we're bumping from 5.3 all the way to 7.3? Doesn't seem like we have any new features we're adding that require 7.3 so just wondering on the reason here? I think for sure we should drop support for 5.3 at this point but maybe we just bump to 7.0? We also need to update the README.md file as well, as that mentions 5.3 as the minimum supported version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, we should keep 7.0 support. Updated both readme files and added 7.0 to compatibility testing.
The initial bump 7.3 was made together with composer dependency (PHPUnit 9.5 requires at least PHP 7.3). This is dev-only requirement and of course the plugin itself works well with 7.0.
There's some merge conflicts here that need fixing |
# Conflicts resolved: # package.json # readme.txt
@dkotter resolved conflicts and fixed PHP minimum reqs in readme files. I also reduced the number of Unit tests just to cover latest PHP 7 and 8, not sure it makes sense to test against every release within a major version. We still test compatibility against 7.0, 7.4, 8.0 and 8.1 in separate workflow |
Description of the Change
Added tests for compatibility against PHP7 and PHP8:
Updated PHPUnit to 9.5, updated unit tests to be compatible with 9.5
Verification Process
Check GitHub Actions workflows all pass.
Checklist:
Changelog Entry
Added - Compatibility tests against PHP 7 and 8.
Changed - Unit tests against PHP 8
Changed - Bump required PHP 7.0