Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add version links to CHANGELOG.md #45

Merged
merged 1 commit into from
May 14, 2020
Merged

add version links to CHANGELOG.md #45

merged 1 commit into from
May 14, 2020

Conversation

jeffpaul
Copy link
Member

@jeffpaul jeffpaul commented May 7, 2020

Description of the Change

In reviewing the plugin for a potential release planning, I noticed we were missing links on our versions in CHANGELOG.md. This PR adds those links.

Alternate Designs

n/a

Benefits

Allows someone to view the commits within individual releases based on the GitHub compare function.

Possible Drawbacks

none identified.

Verification Process

Manually verified via the GitHub web UI.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

n/a

@jeffpaul jeffpaul added the needs:documentation This requires documentation. label May 7, 2020
@jeffpaul jeffpaul added this to the 2.2 milestone May 7, 2020
@jeffpaul jeffpaul requested a review from dinhtungdu May 7, 2020 01:56
@jeffpaul jeffpaul self-assigned this May 7, 2020
dinhtungdu
dinhtungdu approved these changes May 7, 2020
View reviewed changes
Copy link
Contributor

@dinhtungdu dinhtungdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked all links, all work great!

@jeffpaul jeffpaul merged commit b31d9af into develop May 14, 2020
@jeffpaul jeffpaul deleted the update/changelog branch June 30, 2020 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinhtungdu dinhtungdu dinhtungdu approved these changes

Assignees

@jeffpaul jeffpaul

Labels
needs:documentation This requires documentation.
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffpaul @dinhtungdu