Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping tested up to version. #43

Merged
merged 2 commits into from May 1, 2020
Merged

Bumping tested up to version. #43

merged 2 commits into from May 1, 2020

Conversation

ghost
Copy link

@ghost ghost commented Apr 4, 2020

Bumping WP tested up to version to 5.4. I followed the same verification process as here.

For #42

@jeffpaul jeffpaul assigned ghost Apr 7, 2020
@jeffpaul jeffpaul added this to the 2.2 milestone Apr 7, 2020
@jeffpaul
Copy link
Member

jeffpaul commented Apr 7, 2020

@helen we'll need to update this to merge into master to trigger the GitHub Action, yeah?

@jeffpaul jeffpaul merged commit b71d650 into 10up:develop May 1, 2020
@jeffpaul
Copy link
Member

jeffpaul commented May 1, 2020

I went ahead and pushed the same change to master to trigger the readme/asset action, but nothing happened. Turns out our actions in master are the old format and won't work. Sigh, we'll have to wait for a release here to get things back in order on master.

@helen
Copy link
Contributor

helen commented May 1, 2020

@jeffpaul Should be okay to update the workflow file in master and it'll run when merging that :)

@jeffpaul jeffpaul mentioned this pull request May 6, 2020
6 tasks
@jeffpaul
Copy link
Member

jeffpaul commented May 7, 2020

Thanks @helen that worked (see #44) though the odd thing is dotorg now shows tested-up-to 5.4.1 but our readme.txt shows 5.4. Not a major issue, just not sure how that discrepancy snuck in.

@helen
Copy link
Contributor

helen commented May 7, 2020

@jeffpaul .org only requires that we bump majors :)

@jeffpaul
Copy link
Member

jeffpaul commented May 7, 2020

@helen I'm aware of that, my head-scratcher was that our readme.txt states 5.4 while the plugin page on dotorg shows 5.4.1. I'm not certain how dotorg inferred 5.4.1 from our stated 5.4?

@helen
Copy link
Contributor

helen commented May 7, 2020

@jeffpaul Right, we only bump majors, and .org assumes/displays the latest minor in that major branch

@jeffpaul
Copy link
Member

jeffpaul commented May 7, 2020

Huh, ok. That's a bit odd and potentially concerning as theoretically there could be an conflict between a plugin and a WP minor, especially now that minor releases can include enhancements, that would only be caught in specific testing against a minor versus against a major release.

@jeffpaul jeffpaul mentioned this pull request Jun 8, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants