-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix i18n issues #295
Fix i18n issues #295
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pedro-mendonca Thanks for the PR, this looks and tests great!
@faisal-alvi if the site language is set to Language A, and user-language is set to Language B, all these strings are presented in Language B. |
That's a good callout and is something I tested. I see the proper translations both if a site language is set and if a user language is set when testing this PR. Not sure if there are other changes we've made that helped fix this since the original issue was reported but I'm not seeing any regression, though feel free to test yourself to ensure that is the case |
Description of the Change
Please see issue #294 for a full issue description and screenshots.
Closes #294
How to test the Change
Install a language that the plugin is 100% translated
Go to Settings > Discussion and see all the plugin related strings translated.
Changelog Entry
Fixed - I18n issues
Credits
Props @pedro-mendonca
Checklist: