Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the download-artifact from v3 to v4 #265

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

iamdharmesh
Copy link
Member

Description of the Change

The PR proposes upgrading the download-artifact to v4. This upgrade is related to the upgrade of upload-artifact to v4 in PR 10up/action-wordpress-plugin-build-zip#3. Version 4 contains breaking changes, and this PR ensures that everything keeps working after the build zip action updates the upload-artifact to v4.

Note

Please merge this PR after the action https://github.com/marketplace/actions/wordpress-plugin-build-zip gets released.

How to test the Change

Please ensure that the E2E test action runs successfully after the release of the action available at https://github.com/marketplace/actions/wordpress-plugin-build-zip.

Changelog Entry

Changed - Upgrade the download-artifact from v3 to v4

Credits

Props @iamdharmesh

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@iamdharmesh iamdharmesh requested a review from jeffpaul as a code owner March 19, 2024 16:25
@github-actions github-actions bot added this to the 2.8.0 milestone Mar 19, 2024
@github-actions github-actions bot added the needs:code-review This requires code review. label Mar 19, 2024
@iamdharmesh iamdharmesh merged commit cfb31fb into develop Mar 21, 2024
13 checks passed
@iamdharmesh iamdharmesh deleted the upkeep/download-artifact branch March 21, 2024 17:25
@faisal-alvi faisal-alvi modified the milestones: 2.8.0, 2.7.8 May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants