Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed trailing commas #196

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Conversation

sekra24
Copy link
Contributor

@sekra24 sekra24 commented Jan 31, 2023

Hey @dkotter, just removed the trailing commas from the code. This should fix the issue with latest PHP versions 7+

Description of the Change

Removed the trailing commas from gettext call on line 527, 529, 531 and 533

Closes #195

How to test the Change

Changelog Entry

Fixed - Remove trailing commas in function calls.

Credits

Props @sekra24

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

Copy link
Member

@faisal-alvi faisal-alvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sekra24 thanks for the PR! LGTM 🚀

@faisal-alvi faisal-alvi merged commit 95d3f15 into 10up:develop Feb 1, 2023
@faisal-alvi faisal-alvi added this to the 2.7.4 milestone Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP error due to trailing commas
2 participants