Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/2.7.1 #178

Merged
merged 9 commits into from
Dec 8, 2022
Merged

Release/2.7.1 #178

merged 9 commits into from
Dec 8, 2022

Conversation

faisal-alvi
Copy link
Member

@faisal-alvi faisal-alvi commented Dec 8, 2022

Description of the Change

This is a follow-up release of 1.7.0 which did not include all the latest files. After merging #170 from Github, we are required to take the latest pull of a develop branch locally (<- that is missed) and then merge it in the trunk. I've added a new step in the release list that will remind you to take a pull in the local before merging the develop into the trunk to avoid this in the future.

Release and version bump to 2.7.1! 🎉

Closes #177

How to test the Change

Verify manually via any IDE and the GitHub Desktop UI.

Credits

Props @faisal-alvi

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@faisal-alvi faisal-alvi added this to the 2.7.1 milestone Dec 8, 2022
@faisal-alvi faisal-alvi self-assigned this Dec 8, 2022
@faisal-alvi faisal-alvi requested a review from dkotter December 8, 2022 10:19
CHANGELOG.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@dkotter
Copy link
Collaborator

dkotter commented Dec 8, 2022

@faisal-alvi This looks good to me. I've almost done the same thing since it's not specifically called out in the release instructions. I'd recommend we fix this in our default files as well: https://github.com/10up/.github/blob/trunk/CONTRIBUTING.md#release-instructions

Also, ideally this is something that would have been caught as part of our new testing step. So just want to reiterate that we should be testing that release zip and as part of that, ensuring that zip has all the files we expect, ensuring it installs and activates correctly, ensuring the version number that shows in the WordPress admin is correct and then doing some lightweight feature testing.

@faisal-alvi faisal-alvi merged commit 5871992 into develop Dec 8, 2022
@faisal-alvi faisal-alvi deleted the release/2.7.1 branch December 8, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release 2.7.1
2 participants