-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/2.7.1 #178
Release/2.7.1 #178
Conversation
@faisal-alvi This looks good to me. I've almost done the same thing since it's not specifically called out in the release instructions. I'd recommend we fix this in our default files as well: https://github.com/10up/.github/blob/trunk/CONTRIBUTING.md#release-instructions Also, ideally this is something that would have been caught as part of our new testing step. So just want to reiterate that we should be testing that release zip and as part of that, ensuring that zip has all the files we expect, ensuring it installs and activates correctly, ensuring the version number that shows in the WordPress admin is correct and then doing some lightweight feature testing. |
Description of the Change
This is a follow-up release of 1.7.0 which did not include all the latest files. After merging #170 from Github, we are required to take the latest pull of a
develop
branch locally (<- that is missed) and then merge it in thetrunk
. I've added a new step in the release list that will remind you to take a pull in the local before merging the develop into the trunk to avoid this in the future.Release and version bump to 2.7.1! 🎉
Closes #177
How to test the Change
Verify manually via any IDE and the GitHub Desktop UI.
Credits
Props @faisal-alvi
Checklist: